From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Takashi Iwai <tiwai@suse.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: Use scnprintf() for avoiding potential buffer overflow
Date: Thu, 12 Mar 2020 23:52:43 -0700 [thread overview]
Message-ID: <20200313065243.GA5198@infradead.org> (raw)
In-Reply-To: <20200312222701.GK10776@dread.disaster.area>
FYI, the right fix for sysfs would be to simply offer a new variant
of ->show using the seq_file infrastructure. That will take care
of all the bounds checking in a maintainable and well understood way.
prev parent reply other threads:[~2020-03-13 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 9:35 [PATCH] xfs: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11 18:21 ` Darrick J. Wong
2020-03-11 20:00 ` Takashi Iwai
2020-03-11 22:09 ` Dave Chinner
2020-03-12 7:01 ` Takashi Iwai
2020-03-12 22:27 ` Dave Chinner
2020-03-12 22:43 ` Darrick J. Wong
2020-03-13 5:00 ` Dave Chinner
2020-03-13 7:18 ` Takashi Iwai
2020-03-13 15:52 ` Darrick J. Wong
2020-03-15 8:49 ` Takashi Iwai
2020-03-13 6:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313065243.GA5198@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox