From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, bfoster@redhat.com
Subject: Re: [PATCH 1/7] xfs: introduce fake roots for ag-rooted btrees
Date: Mon, 16 Mar 2020 08:03:54 -0700 [thread overview]
Message-ID: <20200316150353.GC256767@magnolia> (raw)
In-Reply-To: <20200316104106.GA9730@infradead.org>
On Mon, Mar 16, 2020 at 03:41:06AM -0700, Christoph Hellwig wrote:
> > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> > index 135f4478aa5a..3b0b21a4dcde 100644
> > --- a/fs/xfs/Makefile
> > +++ b/fs/xfs/Makefile
> > @@ -41,6 +41,7 @@ xfs-y += $(addprefix libxfs/, \
> > xfs_bmap.o \
> > xfs_bmap_btree.o \
> > xfs_btree.o \
> > + xfs_btree_staging.o \
>
> We only needs this for online repair don't we? Can we exclude the
> file from the build for xfs configs without scrub/repair?
That could be done, provided we don't mind having #ifdef
CONFIG_XFS_ONLINE_REPAIR checks in the parts of libxfs that call
xfs_btree_commit_afakeroot and xfs_btree_stage_*fakeroot.
After which we'll have to work around that in xfsprogs when I (re)send
my series to refactor all the open-coded btree creation code out of
xfs_repair.
Not a big deal if others want to save ~9k of space (debug mode is on):
text data bss dec hex filename
8767 313 0 9080 2378 fs/xfs/libxfs/xfs_btree_staging.o
--D
next prev parent reply other threads:[~2020-03-16 15:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 23:50 [PATCH v5 0/7] xfs: btree bulk loading Darrick J. Wong
2020-03-15 23:50 ` [PATCH 1/7] xfs: introduce fake roots for ag-rooted btrees Darrick J. Wong
2020-03-16 10:41 ` Christoph Hellwig
2020-03-16 15:03 ` Darrick J. Wong [this message]
2020-03-15 23:50 ` [PATCH 2/7] xfs: introduce fake roots for inode-rooted btrees Darrick J. Wong
2020-03-15 23:50 ` [PATCH 3/7] xfs: support bulk loading of staged btrees Darrick J. Wong
2020-03-15 23:51 ` [PATCH 4/7] xfs: add support for free space btree staging cursors Darrick J. Wong
2020-03-16 12:29 ` Brian Foster
2020-03-16 14:58 ` Darrick J. Wong
2020-03-16 19:35 ` [PATCH v2 " Darrick J. Wong
2020-03-17 11:37 ` Brian Foster
2020-03-15 23:51 ` [PATCH 5/7] xfs: add support for inode " Darrick J. Wong
2020-03-16 12:29 ` Brian Foster
2020-03-15 23:51 ` [PATCH 6/7] xfs: add support for refcount " Darrick J. Wong
2020-03-16 12:29 ` Brian Foster
2020-03-15 23:51 ` [PATCH 7/7] xfs: add support for rmap " Darrick J. Wong
2020-03-16 12:30 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2020-03-12 3:45 [PATCH v4 0/7] xfs: btree bulk loading Darrick J. Wong
2020-03-12 3:45 ` [PATCH 1/7] xfs: introduce fake roots for ag-rooted btrees Darrick J. Wong
2020-03-13 14:47 ` Brian Foster
2020-03-13 16:30 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316150353.GC256767@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox