From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B376EC1975A for ; Tue, 17 Mar 2020 18:34:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83C2A20714 for ; Tue, 17 Mar 2020 18:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dfYmhpjQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbgCQSeE (ORCPT ); Tue, 17 Mar 2020 14:34:04 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44718 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbgCQSeE (ORCPT ); Tue, 17 Mar 2020 14:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ljuPnWgWek1JpOOwQaIQzCzle+H69JeGgzWgmW9NW/c=; b=dfYmhpjQkIyz6eNbFFtPYx11uJ 6lKZaN5iIJh/FDAdlqAoAib357hCiYrR0yo+111/DZkkiYevqDpBs4ZBD01mzpcqsG8dNrxsns2wg LnvuIOWH1G2ioseBFOYZb894I0gjQKZ6iuz1PW7ObjCYI/9me3LAJj9oM/TlhxauN5PwopXg9Tu9k DnImIBtj3LS4OedY7ViUPkviCzDaLSqQF/KJ877/8nI3RKqQsk6+DOLYzkVweW9JPF5d5OpTenHM3 LFD9hft/ruf2ENzWVUQVVZ2jiU7T+WLGwrN/3Q/hSbaMvAjTc4sKbrgMPuiCTx5xZKmpAQcApLJv8 V1N+E/rg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEH2R-0008DV-LA; Tue, 17 Mar 2020 18:34:03 +0000 Date: Tue, 17 Mar 2020 11:34:03 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: xfs , Brian Foster Subject: Re: [PATCH] xfs: fix incorrect test in xfs_alloc_ag_vextent_lastblock Message-ID: <20200317183403.GB23580@infradead.org> References: <20200316153155.GE256767@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316153155.GE256767@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Mar 16, 2020 at 08:31:55AM -0700, Darrick J. Wong wrote: > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c > index 337822115bbc..203e74fa64aa 100644 > --- a/fs/xfs/libxfs/xfs_alloc.c > +++ b/fs/xfs/libxfs/xfs_alloc.c > @@ -1514,7 +1514,7 @@ xfs_alloc_ag_vextent_lastblock( > * maxlen, go to the start of this block, and skip all those smaller > * than minlen. > */ > - if (len || args->alignment > 1) { > + if (*len || args->alignment > 1) { > acur->cnt->bc_ptrs[0] = 1; > do { > error = xfs_alloc_get_rec(acur->cnt, bno, len, &i); The change definitivelly restores the old behavior. Looks good: Reviewed-by: Christoph Hellwig