From: Christoph Hellwig <hch@infradead.org>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] xfs: use more suitable method to get the quota limit value
Date: Tue, 17 Mar 2020 11:58:45 -0700 [thread overview]
Message-ID: <20200317185845.GA4168@infradead.org> (raw)
In-Reply-To: <1584439170-20993-1-git-send-email-kaixuxia@tencent.com>
On Tue, Mar 17, 2020 at 05:59:30PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> It is more suitable to use min_not_zero() to get the quota limit
> value, means to choose the minimum value not the softlimit firstly.
> And the meaning is more clear even though the hardlimit value must
> be larger than softlimit value.
Suitable seems like a rather overblown word, but the actual change looks
fine to me, min_not_zero has grown on me..
next prev parent reply other threads:[~2020-03-17 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:59 [PATCH] xfs: use more suitable method to get the quota limit value xiakaixu1987
2020-03-17 14:34 ` Eric Sandeen
2020-03-17 14:53 ` Bill O'Donnell
2020-03-17 18:58 ` Christoph Hellwig [this message]
2020-03-17 22:45 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317185845.GA4168@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).