From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v7 0/4] xfs: Remove wrappers for some semaphores
Date: Sun, 22 Mar 2020 20:28:09 -0700 [thread overview]
Message-ID: <20200323032809.GA29339@magnolia> (raw)
In-Reply-To: <20200320210317.1071747-1-preichl@redhat.com>
On Fri, Mar 20, 2020 at 10:03:13PM +0100, Pavel Reichl wrote:
> Remove some wrappers that we have in XFS around the read-write semaphore
> locks.
>
> The goal of this cleanup is to remove mrlock_t structure and its mr*()
> wrapper functions and replace it with native rw_semaphore type and its
> native calls.
Hmmm, there's something funny about this patchset that causes my fstests
vm to explode with isilocked assertions everywhere... I'll look more
tomorrow (it's still the weekend here) but figured I should tell you
sooner than later.
--D
> Pavel Reichl (4):
> xfs: Refactor xfs_isilocked()
> xfs: clean up whitespace in xfs_isilocked() calls
> xfs: xfs_isilocked() can only check a single lock type
> xfs: replace mrlock_t with rw_semaphores
>
> fs/xfs/libxfs/xfs_bmap.c | 8 +--
> fs/xfs/mrlock.h | 78 -----------------------------
> fs/xfs/xfs_file.c | 3 +-
> fs/xfs/xfs_inode.c | 104 ++++++++++++++++++++++++++-------------
> fs/xfs/xfs_inode.h | 25 ++++++----
> fs/xfs/xfs_iops.c | 4 +-
> fs/xfs/xfs_linux.h | 2 +-
> fs/xfs/xfs_qm.c | 2 +-
> fs/xfs/xfs_super.c | 6 +--
> 9 files changed, 98 insertions(+), 134 deletions(-)
> delete mode 100644 fs/xfs/mrlock.h
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-03-23 3:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 21:03 [PATCH v7 0/4] xfs: Remove wrappers for some semaphores Pavel Reichl
2020-03-20 21:03 ` [PATCH v7 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-03-20 21:03 ` [PATCH v7 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-03-20 21:03 ` [PATCH v7 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-03-20 21:03 ` [PATCH v7 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-03-23 3:28 ` Darrick J. Wong [this message]
2020-03-23 9:22 ` [PATCH v7 0/4] xfs: Remove wrappers for some semaphores Pavel Reichl
2020-03-23 16:33 ` Darrick J. Wong
2020-03-23 16:49 ` Christoph Hellwig
2020-03-23 21:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323032809.GA29339@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).