From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: xfs: clean up log tickets and record writes v2
Date: Tue, 24 Mar 2020 07:43:10 -0400 [thread overview]
Message-ID: <20200324114310.GA3148@bfoster> (raw)
In-Reply-To: <20200323130706.300436-1-hch@lst.de>
On Mon, Mar 23, 2020 at 02:06:57PM +0100, Christoph Hellwig wrote:
> This series follows up on conversions about relogging infrastructure
> and the way xfs_log_done() does two things but only one of several
> callers uses both of those functions. It also pointed out that
> xfs_trans_commit() never writes to the log anymore, so only
> checkpoints pass a ticket to xlog_write() with this flag set and
> no transaction makes multiple calls to xlog_write() calls on the
> same ticket. Hence there's no real need for XLOG_TIC_INITED to track
> whether a ticket has written a start record to the log anymore.
>
> A lot of further cleanups fell out of this. Once we no longer use
> XLOG_TIC_INITED to carry state inside the write loop, the logic
> can be simplified in both xlog_write and xfs_log_done. xfs_log_done
> can be split up, and then the call chain can be flattened because
> xlog_write_done() and xlog_commit_record() are basically the same.
>
> This then leads to cleanups writing both commit and unmount records.
>
> Finally, to complete what started all this, the XLOG_TIC_INITED flag
> is removed.
>
> A git tree is avaiblable here:
>
> git://git.infradead.org/users/hch/xfs.git xlog-ticket-cleanup.2
>
> Gitweb:
>
> http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xlog-ticket-cleanup.2
>
>
> Changes since v1:
> - taking this over from Dave (for now) as he is still injured, an it
> interacts closely with my log error handling bits
> - rebased on top of for-next + the "more log cleanups" series
> - fix an accounting error in xlog_write
> - use a bool for the ticket header in xlog_write
> - add a new patch to split xlog_ticket_done
>
This seems to ignore various bits of (trivial) feedback from v1 as well
as drops all reviews...
Brian
next prev parent reply other threads:[~2020-03-24 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:06 xfs: clean up log tickets and record writes v2 Christoph Hellwig
2020-03-23 13:06 ` [PATCH 1/9] xfs: don't try to write a start record into every iclog Christoph Hellwig
2020-03-23 13:06 ` [PATCH 2/9] xfs: re-order initial space accounting checks in xlog_write Christoph Hellwig
2020-03-23 13:07 ` [PATCH 3/9] xfs: refactor and split xfs_log_done() Christoph Hellwig
2020-03-23 13:07 ` [PATCH 4/9] xfs: split xlog_ticket_done Christoph Hellwig
2020-03-24 0:09 ` Dave Chinner
2020-03-23 13:07 ` [PATCH 5/9] xfs: merge xlog_commit_record with xlog_write_done() Christoph Hellwig
2020-03-23 13:07 ` [PATCH 6/9] xfs: factor out unmount record writing Christoph Hellwig
2020-03-23 13:07 ` [PATCH 7/9] xfs: rename the log unmount writing functions Christoph Hellwig
2020-03-23 13:07 ` [PATCH 8/9] xfs: remove some stale comments from the log code Christoph Hellwig
2020-03-23 13:07 ` [PATCH 9/9] xfs: kill XLOG_TIC_INITED Christoph Hellwig
2020-03-24 11:43 ` Brian Foster [this message]
2020-03-24 12:40 ` xfs: clean up log tickets and record writes v2 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324114310.GA3148@bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox