From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D76C10DCE for ; Tue, 24 Mar 2020 23:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA83020663 for ; Tue, 24 Mar 2020 23:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgCXXT1 (ORCPT ); Tue, 24 Mar 2020 19:19:27 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:34512 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgCXXT1 (ORCPT ); Tue, 24 Mar 2020 19:19:27 -0400 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 7FD2E7EB46A; Wed, 25 Mar 2020 10:19:24 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jGspP-0005Lq-QY; Wed, 25 Mar 2020 10:19:23 +1100 Date: Wed, 25 Mar 2020 10:19:23 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: xfs , Eric Sandeen Subject: Re: [PATCH v2] xfs: preserve default grace interval during quotacheck Message-ID: <20200324231923.GA10776@dread.disaster.area> References: <20200324210146.GR29339@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324210146.GR29339@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=SS2py6AdgQ4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Ij_YGFVb5y_pWyGX6ysA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Mar 24, 2020 at 02:01:46PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > When quotacheck runs, it zeroes all the timer fields in every dquot. > Unfortunately, it also does this to the root dquot, which erases any > preconfigured grace intervals and warning limits that the administrator > may have set. Worse yet, the incore copies of those variables remain > set. This cache coherence problem manifests itself as the grace > interval mysteriously being reset back to the defaults at the /next/ > mount. > > Fix it by not resetting the root disk dquot's timer and warning fields. > > Signed-off-by: Darrick J. Wong Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com