Re: [PATCH 5/8] xfs: correctly acount for reclaimable slabs

Allison Collins
2020-03-25T04:44:01Z

On 3/24/20 6:42 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The XFS inode item slab actually reclaimed by inode shrinker
> callbacks from the memory reclaim subsystem. These should be marked
> as reclaimable so the mm subsystem has the full picture of how much
> memory it can actually reclaim from the XFS slab caches.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks fine
Reviewed-by: Allison Collins <allison.henderson@oracle.com>

> ---
> fs/xfs/xfs_super.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 2094386af8aca..68fea439d9743 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1861,7 +1861,8 @@ xfs_init_zones(void)
>
> xfs_ili_zone = kmem_cache_create("xfs_ili",
> sizeof(struct xfs_inode_log_item), 0,
> - SLAB_MEM_SPREAD, NULL);
> + SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD,
> + NULL);
> if (!xfs_ili_zone)
> goto out_destroy_inode_zone;
>
>