From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH v2] xfs: preserve default grace interval during quotacheck
Date: Wed, 25 Mar 2020 00:13:18 -0700 [thread overview]
Message-ID: <20200325071318.GB17629@infradead.org> (raw)
In-Reply-To: <20200324210146.GR29339@magnolia>
On Tue, Mar 24, 2020 at 02:01:46PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When quotacheck runs, it zeroes all the timer fields in every dquot.
> Unfortunately, it also does this to the root dquot, which erases any
> preconfigured grace intervals and warning limits that the administrator
> may have set. Worse yet, the incore copies of those variables remain
> set. This cache coherence problem manifests itself as the grace
> interval mysteriously being reset back to the defaults at the /next/
> mount.
>
> Fix it by not resetting the root disk dquot's timer and warning fields.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good, although a comment in the code about the special nature
of qid 0 might be useful. Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-03-25 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:01 [PATCH v2] xfs: preserve default grace interval during quotacheck Darrick J. Wong
2020-03-24 23:19 ` Dave Chinner
2020-03-25 7:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325071318.GB17629@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox