From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
Brian Foster <bfoster@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: don't write a corrupt unmount record to force summary counter recalc
Date: Fri, 27 Mar 2020 02:06:09 -0700 [thread overview]
Message-ID: <20200327090609.GB14052@infradead.org> (raw)
In-Reply-To: <20200327011417.GF29339@magnolia>
On Thu, Mar 26, 2020 at 06:14:17PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In commit f467cad95f5e3, I added the ability to force a recalculation of
> the filesystem summary counters if they seemed incorrect. This was done
> (not entirely correctly) by tweaking the log code to write an unmount
> record without the UMOUNT_TRANS flag set. At next mount, the log
> recovery code will fail to find the unmount record and go into recovery,
> which triggers the recalculation.
>
> What actually gets written to the log is what ought to be an unmount
> record, but without any flags set to indicate what kind of record it
> actually is. This worked to trigger the recalculation, but we shouldn't
> write bogus log records when we could simply write nothing.
>
> Fixes: f467cad95f5e3 ("xfs: force summary counter recalc at next mount")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good (assuming the "xfs: refactor unmount record writing" is
applied):
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-03-27 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 1:14 [PATCH] xfs: don't write a corrupt unmount record to force summary counter recalc Darrick J. Wong
2020-03-27 9:06 ` Christoph Hellwig [this message]
2020-03-27 12:31 ` Brian Foster
2020-03-29 23:04 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327090609.GB14052@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox