Re: [PATCH 1/2] xfs: trylock underlying buffer on dquot flush

Christoph Hellwig
2020-03-27T12:59:54Z

On Thu, Mar 26, 2020 at 09:17:02AM -0400, Brian Foster wrote:
> A dquot flush currently blocks on the buffer lock for the underlying
> dquot buffer. In turn, this causes xfsaild to block rather than
> continue processing other items in the meantime. Update
> xfs_qm_dqflush() to trylock the buffer, similar to how inode buffers
> are handled, and return -EAGAIN if the lock fails. Fix up any
> callers that don't currently handle the error properly.

Looks good, seems like the two remaining xfs_qm_dqflush have
sensible -EAGAIN handling.

Reviewed-by: Christoph Hellwig <hch@lst.de>