From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] iomap: Add iomap_iter API
Date: Wed, 1 Apr 2020 12:20:38 -0700 [thread overview]
Message-ID: <20200401192038.GJ21484@bombadil.infradead.org> (raw)
In-Reply-To: <20200401154248.GA2813@infradead.org>
On Wed, Apr 01, 2020 at 08:42:48AM -0700, Christoph Hellwig wrote:
> OTOH the len argument / return value seems like something that would
> seems useful in the iter structure. That would require renaming the
> current len to something like total_len..
Ah, I remembered why I didn't do it that way. For more complicated
users (eg readahead ...), we want to be able to pass an errno here.
Then iomap_iter() will call ops->iomap_end() and return the errno
you passed in, and we can terminate the loop.
next prev parent reply other threads:[~2020-04-01 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 15:25 [RFC 0/2] Begin switching iomap from apply to iter Matthew Wilcox
2020-04-01 15:25 ` [PATCH 1/2] iomap: Add iomap_iter API Matthew Wilcox
2020-04-01 15:42 ` Christoph Hellwig
2020-04-01 18:42 ` Matthew Wilcox
2020-04-22 15:19 ` Jan Kara
2020-04-01 19:20 ` Matthew Wilcox [this message]
2020-04-02 7:48 ` Christoph Hellwig
2020-04-01 15:25 ` [PATCH 2/2] iomap: Convert page_mkwrite to iter API Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401192038.GJ21484@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).