From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: reflink should force the log out if mounted with wsync
Date: Thu, 2 Apr 2020 08:20:16 -0700 [thread overview]
Message-ID: <20200402152016.GA19701@infradead.org> (raw)
In-Reply-To: <20200402151431.GG80283@magnolia>
On Thu, Apr 02, 2020 at 08:14:31AM -0700, Darrick J. Wong wrote:
> This isn't enough because this is only the last transaction in the
> reflink sequence if we have to set the destination inode's size. If
> (say) we're reflinking a range inside EOF of two files that were already
> sharing blocks, we still won't force the log out.
>
> The other thing I thought of was simply invoking fsync after dropping
> the iolock, but that seemed like more work than was strictly necessary
> to land the reflink transactions on disk.
Well, we have a lightweight version of fsync doing just that. In
fact we have the same lightweight version twice: xfs_dir_fsync and
xfs_fs_nfs_commit_metadata.
next prev parent reply other threads:[~2020-04-02 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 4:17 [PATCH] xfs: reflink should force the log out if mounted with wsync Darrick J. Wong
2020-04-02 7:51 ` Christoph Hellwig
2020-04-02 8:49 ` Christoph Hellwig
2020-04-02 14:53 ` Darrick J. Wong
2020-04-02 14:56 ` Christoph Hellwig
2020-04-02 15:14 ` Darrick J. Wong
2020-04-02 15:20 ` Christoph Hellwig [this message]
2020-04-02 21:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402152016.GA19701@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox