From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] generic: test PF_MEMALLOC interfering with accounting file write
Date: Thu, 2 Apr 2020 21:32:52 -0700 [thread overview]
Message-ID: <20200403043252.GL80283@magnolia> (raw)
In-Reply-To: <20200403040215.GA11203@sol.localdomain>
On Thu, Apr 02, 2020 at 09:02:15PM -0700, Eric Biggers wrote:
> On Thu, Apr 02, 2020 at 08:56:57PM -0700, Darrick J. Wong wrote:
> > > +_scratch_mount
> > > +_scratch_unmount
> >
> > _scratch_cycle_mount
> >
> > With that fixed,
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
>
> That doesn't work because _scratch_cycle_mount does unmount, then mount.
> This test wants mount, then unmount.
LOL, and I even stumbled over the same thing last time. :(
Test looks fine as it is, and you can still add my RVB.
Ok, time to go do something else.
--D
--D
> - Eric
prev parent reply other threads:[~2020-04-03 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 3:33 [PATCH v2] generic: test PF_MEMALLOC interfering with accounting file write Eric Biggers
2020-04-03 3:56 ` Darrick J. Wong
2020-04-03 4:02 ` Eric Biggers
2020-04-03 4:32 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403043252.GL80283@magnolia \
--to=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox