From: Christoph Hellwig <hch@infradead.org>
To: Chandan Rajendra <chandan@linux.ibm.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>,
Chandan Rajendra <chandanrlinux@gmail.com>,
fstests@vger.kernel.org, hch@infradead.org
Subject: Re: xfs_check vs. xfs_repair vs. the world^W^Wfstests
Date: Thu, 9 Apr 2020 00:40:28 -0700 [thread overview]
Message-ID: <20200409074028.GB21033@infradead.org> (raw)
In-Reply-To: <2574725.68tNun6CyS@localhost.localdomain>
On Wed, Apr 08, 2020 at 10:23:21AM +0530, Chandan Rajendra wrote:
> > Not sure what to do about quota in repair -- we could build in the
> > ability to do quota counts since we scan the whole inode table and
> > directory tree anyway. From there it's not so hard to rebuild the quota
> > inodes too.
> >
>
> I will take up this work and get it completed.
>
> Since I have other higher priority tasks at work place, I will have this as my
> secondary focus. Meanwhile, until it gets done, can we disable running these
> tests on block size > 4k i.e. https://patchwork.kernel.org/patch/11454399/.
I still think even with the above outstanding issues we should not
run check by default. We can still opt into it, but check extends
the run time of xfstests for not very good reasons.
next prev parent reply other threads:[~2020-04-09 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 3:00 xfs_check vs. xfs_repair vs. the world^W^Wfstests Darrick J. Wong
2020-04-08 4:53 ` Chandan Rajendra
2020-04-09 7:40 ` Christoph Hellwig [this message]
2020-04-09 14:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409074028.GB21033@infradead.org \
--to=hch@infradead.org \
--cc=chandan@linux.ibm.com \
--cc=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox