Re: [PATCH] xfs: simplify the flags setting in xfs_qm_scall_quotaon

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Fri, Apr 10, 2020 at 04:57:04PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> Simplify the setting of the flags value, and only consider
> quota enforcement stuff here.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
>  fs/xfs/xfs_qm_syscalls.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
> index 5d5ac65..944486f 100644
> --- a/fs/xfs/xfs_qm_syscalls.c
> +++ b/fs/xfs/xfs_qm_syscalls.c
> @@ -357,11 +357,11 @@

No idea which function this is.  diff -p, please.

Also, please consider putting all these minor cleanups into a single
patchset, it's a lot easier (for me) to track and land one series than
it is to handle a steady trickle of single patches.

--D

>  	int		error;
>  	uint		qf;
>  
> -	flags &= (XFS_ALL_QUOTA_ACCT | XFS_ALL_QUOTA_ENFD);
>  	/*
> -	 * Switching on quota accounting must be done at mount time.
> +	 * Switching on quota accounting must be done at mount time,
> +	 * only consider quota enforcement stuff here.
>  	 */
> -	flags &= ~(XFS_ALL_QUOTA_ACCT);
> +	flags &= XFS_ALL_QUOTA_ENFD;
>  
>  	if (flags == 0) {
>  		xfs_debug(mp, "%s: zero flags, m_qflags=%x",
> -- 
> 1.8.3.1
>