linux-next: Fixes tag needs some work in the xfs tree

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hi all,

In commit

  4ea899ead278 ("iomap: fix a use after free in iomap_dio_rw")

Fixes tag

  Fixes: ff6a9292e6 ("iomap: implement direct I/O")

has these problem(s):

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the xfs tree

[Dave Chinner]

On Wed, Jan 30, 2019 at 07:56:47AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   4ea899ead278 ("iomap: fix a use after free in iomap_dio_rw")
> 
> Fixes tag
> 
>   Fixes: ff6a9292e6 ("iomap: implement direct I/O")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long

Might be worth adding this to the boiler plate code:

	This can be fixed by adding the following to your ~/.gitconfig file:

	[core]
		abbrev = 12

Thanks!

-Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hi Dave,

On Wed, 30 Jan 2019 09:08:02 +1100 Dave Chinner <david@fromorbit.com> wrote:
>
> Might be worth adding this to the boiler plate code:
> 
> 	This can be fixed by adding the following to your ~/.gitconfig file:
> 
> 	[core]
> 		abbrev = 12

Actually, since git v2.11 (released Nov 29, 2016), abbrev = auto (which
is the default) means that the default scales with the size of the
repository.  For Linus' tree, that currently produces 12 digit commit
SHA1 abbreviations, but will probably soon become 13.  So the best
currently, is to *not* set core.abbrev (or set it to something above 12
(for future robustness).

See
https://lore.kernel.org/lkml/20181220000112.24891-1-avarab@gmail.com/

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the xfs tree

[Dave Chinner]

On Wed, Jan 30, 2019 at 10:06:40AM +1100, Stephen Rothwell wrote:
> Hi Dave,
> 
> On Wed, 30 Jan 2019 09:08:02 +1100 Dave Chinner <david@fromorbit.com> wrote:
> >
> > Might be worth adding this to the boiler plate code:
> > 
> > 	This can be fixed by adding the following to your ~/.gitconfig file:
> > 
> > 	[core]
> > 		abbrev = 12
> 
> Actually, since git v2.11 (released Nov 29, 2016), abbrev = auto (which
> is the default) means that the default scales with the size of the
> repository.  For Linus' tree, that currently produces 12 digit commit
> SHA1 abbreviations, but will probably soon become 13.  So the best
> currently, is to *not* set core.abbrev (or set it to something above 12
> (for future robustness).
> 
> See
> https://lore.kernel.org/lkml/20181220000112.24891-1-avarab@gmail.com/

.... and in replying to correct me demonstrates the exact point I
was making - that documenting what configuration should be used to
avoid the warning acheives far more than just reporting an error.

i.e. all those people who /don't follow git development/ and have
working configs that pre-date the "auto mode" or it being made
the default now know the correct way to configure their repository.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi Dave,

On Wed, 30 Jan 2019 10:43:38 +1100 Dave Chinner <david@fromorbit.com> wrote:
>
> .... and in replying to correct me demonstrates the exact point I
> was making - that documenting what configuration should be used to
> avoid the warning acheives far more than just reporting an error.
> 
> i.e. all those people who /don't follow git development/ and have
> working configs that pre-date the "auto mode" or it being made
> the default now know the correct way to configure their repository.

Point taken.  It now says:

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the xfs tree

[Dave Chinner]

On Wed, Jan 30, 2019 at 11:02:56AM +1100, Stephen Rothwell wrote:
> Hi Dave,
> 
> On Wed, 30 Jan 2019 10:43:38 +1100 Dave Chinner <david@fromorbit.com> wrote:
> >
> > .... and in replying to correct me demonstrates the exact point I
> > was making - that documenting what configuration should be used to
> > avoid the warning acheives far more than just reporting an error.
> > 
> > i.e. all those people who /don't follow git development/ and have
> > working configs that pre-date the "auto mode" or it being made
> > the default now know the correct way to configure their repository.
> 
> Point taken.  It now says:
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Wonderful!

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

In commit

  294fc7a4c8ec ("fs: xfs: xfs_log: Don't use KM_MAYFAIL at xfs_log_reserve().")

Fixes tag

  Fixes: eb01c9cd87 ("[XFS] Remove the xlog_ticket allocator")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

In commit

  826f7e34130a ("xfs: use bitops interface for buf log item AIL flag check")

Fixes tag

  Fixes: 22525c17ed ("xfs: log item flags are racy")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  63dc90feaa20 ("xfs: move inode flush to the sync workqueue")

Fixes tag

  Fixes: bdd4ee4f8407 ("xfs: ratelimit inode flush on buffered write ENOSPC")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: c6425702f21e ("xfs: ratelimit inode flush on buffered write ENOSPC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  43dc0aa84ef7 ("xfs: fix unused variable warning in buffer completion on !DEBUG")

Fixes tag

  Fixes: 7376d745473 ("xfs: random buffer write failure errortag")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  6a458bebafe7 ("xfs: fix broken logic when detecting mergeable bmap records")

Fixes tag

  Fixes: 6bc6c99a944c ("xfs: alert the user about data/attr fork mappings that could be merged")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 336642f79283 ("xfs: alert the user about data/attr fork mappings that could be merged")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

In commit

  74ad4693b647 ("xfs: fix log recovery when unknown rocompat bits are set")

Fixes tag

  Fixes: 9e037cb7972f ("xfs: check for unknown v5 feature bits in superblock write verifier"

has these problem(s):

  - Subject has leading but no trailing parentheses

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

In commit

  df81db024ef7 ("xfs: don't free cowblocks from under dirty pagecache on unshare")

Fixes tag

  Fixes: 46afb0628b ("xfs: only flush the unshared range in xfs_reflink_unshare")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the xfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi all,

In commit

  bc0651d93a7b ("xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n")

Fixes tag

  Fixes: 48a72f60861f79 ("xfs: don't complain about unfixed metadata when repairs were injected")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

maybe you meant

Fixes: 48a72f60861f ("xfs: refactor repair forcing tests into a repair.c helper")

or

Fixes: 8336a64eb75c ("xfs: don't complain about unfixed metadata when repairs were injected")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the xfs tree

[Darrick J. Wong]

On Wed, Feb 12, 2025 at 08:21:41AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   bc0651d93a7b ("xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n")
> 
> Fixes tag
> 
>   Fixes: 48a72f60861f79 ("xfs: don't complain about unfixed metadata when repairs were injected")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
> 
> maybe you meant
> 
> Fixes: 48a72f60861f ("xfs: refactor repair forcing tests into a repair.c helper")
> 
> or
> 
> Fixes: 8336a64eb75c ("xfs: don't complain about unfixed metadata when repairs were injected")

Yes, 8336a64eb75c.

This patch has been on the list for a month now, and nobody complained.
Probably because people aren't good at distinguishing one sequence of
hexadecimal from another.

Could we /please/ have a bot to warn about these annotation problems
when patches are on the list for review, rather than a month later after
it finally enters for-next, without any of the authors, reviewers, or
maintainers having noticed?

Maybe the rest of you are all excellent at this, and I should just fuck
off and quit.

--D

> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the xfs tree

[Carlos Maiolino]

On Tue, Feb 11, 2025 at 02:31:59PM -0800, Darrick J. Wong wrote:
> On Wed, Feb 12, 2025 at 08:21:41AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   bc0651d93a7b ("xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n")
> >
> > Fixes tag
> >
> >   Fixes: 48a72f60861f79 ("xfs: don't complain about unfixed metadata when repairs were injected")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> >         git log -1 --format='Fixes: %h ("%s")'
> >
> > maybe you meant
> >
> > Fixes: 48a72f60861f ("xfs: refactor repair forcing tests into a repair.c helper")
> >
> > or
> >
> > Fixes: 8336a64eb75c ("xfs: don't complain about unfixed metadata when repairs were injected")
> 
> Yes, 8336a64eb75c.
> 
> This patch has been on the list for a month now, and nobody complained.
> Probably because people aren't good at distinguishing one sequence of
> hexadecimal from another.
> 
> Could we /please/ have a bot to warn about these annotation problems
> when patches are on the list for review, rather than a month later after
> it finally enters for-next, without any of the authors, reviewers, or
> maintainers having noticed?
> 
> Maybe the rest of you are all excellent at this, and I should just fuck
> off and quit.
> 

FWIW, I've been working on some scripts to better validate patches, but lacks me
some time, also, a bot would be indeed the best approach.

I don't plan to validate patches until I pull them in, and this will usually
happen way after the patches hit the list. So, Darrick's suggestion to get these
problems early, won't be fixed during integration.


> --D
> 
> > --
> > Cheers,
> > Stephen Rothwell
> 
>