From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C71C3815B for ; Mon, 20 Apr 2020 03:59:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E757C2087E for ; Mon, 20 Apr 2020 03:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725896AbgDTD7C (ORCPT ); Sun, 19 Apr 2020 23:59:02 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:44896 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgDTD7C (ORCPT ); Sun, 19 Apr 2020 23:59:02 -0400 Received: from dread.disaster.area (pa49-180-0-232.pa.nsw.optusnet.com.au [49.180.0.232]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 2773E3A37C4; Mon, 20 Apr 2020 13:59:00 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jQNaE-0008KW-2i; Mon, 20 Apr 2020 13:58:58 +1000 Date: Mon, 20 Apr 2020 13:58:58 +1000 From: Dave Chinner To: Brian Foster Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 08/12] xfs: remove unnecessary quotaoff intent item push handler Message-ID: <20200420035858.GK9800@dread.disaster.area> References: <20200417150859.14734-1-bfoster@redhat.com> <20200417150859.14734-9-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417150859.14734-9-bfoster@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=XYjVcjsg+1UI/cdbgX7I7g==:117 a=XYjVcjsg+1UI/cdbgX7I7g==:17 a=kj9zAlcOel0A:10 a=cl8xLZFz6L8A:10 a=7-415B0cAAAA:8 a=6Z-vhxyNUeLoRVkCRMAA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Apr 17, 2020 at 11:08:55AM -0400, Brian Foster wrote: > The quotaoff intent item push handler unconditionally returns locked > status because it remains AIL resident until removed by the > quotafoff end intent. xfsaild_push_item() already returns pinned > status for items (generally intents) without a push handler. This is > effectively the same behavior for the purpose of quotaoff, so remove It's not the same. XFS_ITEM_PINNED results in a log force from the xfsaild, while XFS_ITEM_LOCKED items are just skipped. So this change will result in a log force every time the AIL push sees a quotaoff log item. Hence I think the code as it stands is correct as log forces will not speed up the removal of the quotaoff item from the AIL... Cheers, Dave. -- Dave Chinner david@fromorbit.com