From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30EBC54FCB for ; Sat, 25 Apr 2020 18:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A41EC206ED for ; Sat, 25 Apr 2020 18:34:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PAw6RYNS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbgDYSeg (ORCPT ); Sat, 25 Apr 2020 14:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726145AbgDYSeg (ORCPT ); Sat, 25 Apr 2020 14:34:36 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 036C4C09B04D for ; Sat, 25 Apr 2020 11:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E496AKGsbqgGfTswD3khclwL1MqulPAEDdG0FKure4Y=; b=PAw6RYNSen5uvz9TxLQ2CIF6Qr lMyrfmipIIaEoW/PDTA6S2L6N//92N32ANp0p6R5pUIAYzoYwAZy0y1oOpPY9e455UIHoSqIUjZun YLf42mF3QCyhYYac7DXswiXq57J7/J4BNi2ZqJeWLBnoJ/TVakSfqe2GMG1OG3F0QTOKPETfLqAJ9 nBvfS1WE52DVemsDiQNQbJYqAIpskpyHLzti1K0yyfubInSK7E0ELSggb6xTnG8jxBC89sfPcd0/g 2oO8x0DYLmKQ2L9EhfB/g6bSlqg7mQhasNI0OZb4qGoRcTuQlExuTQmTlTLg8YSdZlv1xcq99DrVM X7iDmVaQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSPdL-0000v5-T5; Sat, 25 Apr 2020 18:34:35 +0000 Date: Sat, 25 Apr 2020 11:34:35 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 16/19] xfs: refactor adding recovered intent items to the log Message-ID: <20200425183435.GH16698@infradead.org> References: <158752116283.2140829.12265815455525398097.stgit@magnolia> <158752126650.2140829.12864119186355641266.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158752126650.2140829.12864119186355641266.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Apr 21, 2020 at 07:07:46PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > During recovery, every intent that we recover from the log has to be > added to the AIL. Replace the open-coded addition with a helper. Looks good, Reviewed-by: Christoph Hellwig