From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 2/5] xfs/126: make sure we corrupt the attr leaf in a detectable way
Date: Mon, 27 Apr 2020 10:58:28 -0700 [thread overview]
Message-ID: <20200427175828.GN6740@magnolia> (raw)
In-Reply-To: <158768468419.3019327.7338437062843317243.stgit@magnolia>
On Thu, Apr 23, 2020 at 04:31:24PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Try harder to fuzz the attr leaf so this consistently trips a verifier.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
DOH, NAK on this one, you might as well take "xfs/126: make blocktrash
work reliably on attrleaf blocks" from Anthony Iliopoulos.
--D
> ---
> tests/xfs/126 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/tests/xfs/126 b/tests/xfs/126
> index 4f9f8cf9..0d497779 100755
> --- a/tests/xfs/126
> +++ b/tests/xfs/126
> @@ -72,7 +72,7 @@ echo "+ corrupt xattr"
> loff=1
> while true; do
> _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" | grep -q 'file attr block is unmapped' && break
> - _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> + _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -x 4096 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> loff="$((loff + 1))"
> done
>
>
next prev parent reply other threads:[~2020-04-27 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 23:31 [PATCH 0/5] fstests: random fixes Darrick J. Wong
2020-04-23 23:31 ` [PATCH 1/5] generic/590: fix the xfs feature detection logic Darrick J. Wong
2020-04-23 23:31 ` [PATCH 2/5] xfs/126: make sure we corrupt the attr leaf in a detectable way Darrick J. Wong
2020-04-27 17:58 ` Darrick J. Wong [this message]
2020-04-23 23:31 ` [PATCH 3/5] generic/570: don't run this test on systems supporting userspace hibernate Darrick J. Wong
2020-04-24 6:22 ` Christoph Hellwig
2020-04-23 23:31 ` [PATCH 4/5] xfs/30[78]: fix regressions due to strengthened AGF checks Darrick J. Wong
2020-04-24 10:30 ` Christoph Hellwig
2020-04-23 23:31 ` [PATCH 5/5] xfs/122: fix for linux 5.7 stuff Darrick J. Wong
2020-04-24 6:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427175828.GN6740@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox