From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBFBC4CECC for ; Mon, 27 Apr 2020 19:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29CBB205C9 for ; Mon, 27 Apr 2020 19:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbgD0Tch (ORCPT ); Mon, 27 Apr 2020 15:32:37 -0400 Received: from verein.lst.de ([213.95.11.211]:50795 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgD0Tch (ORCPT ); Mon, 27 Apr 2020 15:32:37 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 65CA568C7B; Mon, 27 Apr 2020 21:32:35 +0200 (CEST) Date: Mon, 27 Apr 2020 21:32:35 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: sandeen@sandeen.net, Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH] libxcmd: don't crash if el_gets returns null Message-ID: <20200427193235.GA24732@lst.de> References: <20200427170730.GQ6742@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427170730.GQ6742@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Apr 27, 2020 at 10:07:30AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > el_gets returns NULL if it fails to read any characters (due to EOF or > errors occurred). strdup will crash if it is fed a NULL string, so > check the return value to avoid segfaulting. > > Signed-off-by: Darrick J. Wong Looks good: Reviewed-by: Christoph Hellwig