From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 232CBC83000 for ; Wed, 29 Apr 2020 14:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00A4A2073E for ; Wed, 29 Apr 2020 14:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="koVQc6sg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbgD2Oz7 (ORCPT ); Wed, 29 Apr 2020 10:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726519AbgD2Oz7 (ORCPT ); Wed, 29 Apr 2020 10:55:59 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D9F4C03C1AD for ; Wed, 29 Apr 2020 07:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xXvGuWL7vafZxhtzc5zx2ZM6cL0rWQaDTFPixGl6pHY=; b=koVQc6sgN0XVyswkr0xz/VousU KIkTkFuAwurxjWI3mtErh4fIaIxaUgsqZRwBylCscviSpbihlH+Nm7xAPct/Co4Z8jNplxbiqi7L4 /5AYKCcyqfoHzXHCqn57jjGK0MREbpViQFosGecJmOUEDl3Vj7rIGI/ut7bdaGqv7HWGdfSpBIEM/ sCUsrj3RLdIDfUzTEbnuCDB8Bk1HSgZxZh5R7O19EkFnPzY2k4+WwG0+QV8CIu6WzViK+ThAjE1RM vM4DnmhNd0EyJiqL5GdvpwHULpQU7zJWvBDl/lNG7hrzKBOyZiU9wanSH6EDj85i0exNCul4hTpJX NZ3NXvBQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTo7x-0001KX-3d; Wed, 29 Apr 2020 14:55:57 +0000 Date: Wed, 29 Apr 2020 07:55:57 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Brian Foster , linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/3] xfs: teach deferred op freezer to freeze and thaw inodes Message-ID: <20200429145557.GA26461@infradead.org> References: <158752128766.2142108.8793264653760565688.stgit@magnolia> <158752130655.2142108.9338576917893374360.stgit@magnolia> <20200425190137.GA16009@infradead.org> <20200427113752.GE4577@bfoster> <20200428221747.GH6742@magnolia> <20200429113803.GA33986@bfoster> <20200429114819.GA24120@infradead.org> <20200429142807.GU6742@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429142807.GU6742@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Apr 29, 2020 at 07:28:07AM -0700, Darrick J. Wong wrote: > Hmm. Actually now that I think harder about it, the bmap item is > completely incore and fields are selectively copied to the log item. > This means that regular IO could set bi_owner = and > bi_ip = . Recovery IO can set bi_owner but leave > bi_ip NULL, and then the bmap item replay can iget as needed. Now we > don't need this freeze/thaw thing at all. Yes, that sounds pretty reasonable.