From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Allison Collins <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v8 10/20] xfs: Add helper function __xfs_attr_rmtval_remove
Date: Wed, 29 Apr 2020 16:09:09 -0700 [thread overview]
Message-ID: <20200429230909.GW6742@magnolia> (raw)
In-Reply-To: <20200429230540.GV6742@magnolia>
On Wed, Apr 29, 2020 at 04:05:40PM -0700, Darrick J. Wong wrote:
> On Fri, Apr 03, 2020 at 03:12:19PM -0700, Allison Collins wrote:
> > This function is similar to xfs_attr_rmtval_remove, but adapted to
> > return EAGAIN for new transactions. We will use this later when we
> > introduce delayed attributes. This function will eventually replace
> > xfs_attr_rmtval_remove
> >
> > Signed-off-by: Allison Collins <allison.henderson@oracle.com>
> > Reviewed-by: Chandan Rajendra <chandanrlinux@gmail.com>
>
> Seems reasonable, but oh my the transaction roll hoisting is complex...
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Err... whooops. I meant to send this for patch 13. Maybe I should just
wait for v9 to appear on the list...
--D
> --D
>
> > ---
> > fs/xfs/libxfs/xfs_attr_remote.c | 25 +++++++++++++++++++++++++
> > fs/xfs/libxfs/xfs_attr_remote.h | 1 +
> > 2 files changed, 26 insertions(+)
> >
> > diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
> > index 4d51969..fd4be9d 100644
> > --- a/fs/xfs/libxfs/xfs_attr_remote.c
> > +++ b/fs/xfs/libxfs/xfs_attr_remote.c
> > @@ -711,3 +711,28 @@ xfs_attr_rmtval_remove(
> > }
> > return 0;
> > }
> > +
> > +/*
> > + * Remove the value associated with an attribute by deleting the out-of-line
> > + * buffer that it is stored on. Returns EAGAIN for the caller to refresh the
> > + * transaction and recall the function
> > + */
> > +int
> > +__xfs_attr_rmtval_remove(
> > + struct xfs_da_args *args)
> > +{
> > + int error, done;
> > +
> > + /*
> > + * Unmap value blocks for this attr.
> > + */
> > + error = xfs_bunmapi(args->trans, args->dp, args->rmtblkno,
> > + args->rmtblkcnt, XFS_BMAPI_ATTRFORK, 1, &done);
> > + if (error)
> > + return error;
> > +
> > + if (!done)
> > + return -EAGAIN;
> > +
> > + return 0;
> > +}
> > diff --git a/fs/xfs/libxfs/xfs_attr_remote.h b/fs/xfs/libxfs/xfs_attr_remote.h
> > index eff5f95..ee3337b 100644
> > --- a/fs/xfs/libxfs/xfs_attr_remote.h
> > +++ b/fs/xfs/libxfs/xfs_attr_remote.h
> > @@ -14,4 +14,5 @@ int xfs_attr_rmtval_remove(struct xfs_da_args *args);
> > int xfs_attr_rmtval_stale(struct xfs_inode *ip, struct xfs_bmbt_irec *map,
> > xfs_buf_flags_t incore_flags);
> > int xfs_attr_rmtval_invalidate(struct xfs_da_args *args);
> > +int __xfs_attr_rmtval_remove(struct xfs_da_args *args);
> > #endif /* __XFS_ATTR_REMOTE_H__ */
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2020-04-29 23:09 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 22:12 [PATCH v8 00/20] xfs: Delay Ready Attributes Allison Collins
2020-04-03 22:12 ` [PATCH v8 01/20] xfs: Add xfs_has_attr and subroutines Allison Collins
2020-04-06 14:31 ` Brian Foster
2020-04-06 22:09 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 02/20] xfs: Check for -ENOATTR or -EEXIST Allison Collins
2020-04-06 14:31 ` Brian Foster
2020-04-06 23:14 ` Allison Collins
2020-04-15 6:43 ` Chandan Rajendra
2020-04-03 22:12 ` [PATCH v8 03/20] xfs: Factor out new helper functions xfs_attr_rmtval_set Allison Collins
2020-04-03 22:12 ` [PATCH v8 04/20] xfs: Pull up trans handling in xfs_attr3_leaf_flipflags Allison Collins
2020-04-03 22:12 ` [PATCH v8 05/20] xfs: Split apart xfs_attr_leaf_addname Allison Collins
2020-04-03 22:12 ` [PATCH v8 06/20] xfs: Refactor xfs_attr_try_sf_addname Allison Collins
2020-04-03 22:12 ` [PATCH v8 07/20] xfs: Pull up trans roll from xfs_attr3_leaf_setflag Allison Collins
2020-04-03 22:12 ` [PATCH v8 08/20] xfs: Factor out xfs_attr_rmtval_invalidate Allison Collins
2020-04-03 22:12 ` [PATCH v8 09/20] xfs: Pull up trans roll in xfs_attr3_leaf_clearflag Allison Collins
2020-04-03 22:12 ` [PATCH v8 10/20] xfs: Add helper function __xfs_attr_rmtval_remove Allison Collins
2020-04-07 14:16 ` Brian Foster
2020-04-07 22:19 ` Allison Collins
2020-04-29 23:05 ` Darrick J. Wong
2020-04-29 23:09 ` Darrick J. Wong [this message]
2020-04-03 22:12 ` [PATCH v8 11/20] xfs: Add helper function xfs_attr_node_shrink Allison Collins
2020-04-07 14:17 ` Brian Foster
2020-04-07 21:52 ` Allison Collins
2020-04-15 10:16 ` Chandan Rajendra
2020-04-15 22:13 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 12/20] xfs: Removed unneeded xfs_trans_roll_inode calls Allison Collins
2020-04-07 14:17 ` Brian Foster
2020-04-07 21:53 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 13/20] xfs: Add helpers xfs_attr_is_shortform and xfs_attr_set_shortform Allison Collins
2020-04-07 15:23 ` Brian Foster
2020-04-07 21:53 ` Allison Collins
2020-04-10 16:55 ` Allison Collins
2020-04-11 12:57 ` Brian Foster
2020-04-20 5:30 ` Chandan Rajendra
2020-04-20 22:45 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 14/20] xfs: Add helper function xfs_attr_leaf_mark_incomplete Allison Collins
2020-04-07 15:23 ` Brian Foster
2020-04-07 21:53 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 15/20] xfs: Add remote block helper functions Allison Collins
2020-04-08 12:09 ` Brian Foster
2020-04-08 16:32 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 16/20] xfs: Add helper function xfs_attr_node_removename_setup Allison Collins
2020-04-08 12:09 ` Brian Foster
2020-04-08 16:32 ` Allison Collins
2020-04-20 6:25 ` Chandan Rajendra
2020-04-20 22:46 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 17/20] xfs: Add helper function xfs_attr_node_removename_rmt Allison Collins
2020-04-08 12:10 ` Brian Foster
2020-04-08 16:32 ` Allison Collins
2020-04-20 6:38 ` Chandan Rajendra
2020-04-20 22:46 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 18/20] xfs: Add delay ready attr remove routines Allison Collins
2020-04-13 12:30 ` Brian Foster
2020-04-14 21:35 ` Allison Collins
2020-04-15 11:46 ` Brian Foster
2020-04-16 3:17 ` Allison Collins
2020-04-16 10:58 ` Brian Foster
2020-04-16 22:41 ` Allison Collins
2020-04-20 9:06 ` Chandan Rajendra
2020-04-20 23:26 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 19/20] xfs: Add delay ready attr set routines Allison Collins
2020-04-13 13:40 ` Brian Foster
2020-04-15 22:08 ` Allison Collins
2020-04-16 11:01 ` Brian Foster
2020-04-16 22:54 ` Allison Collins
2020-04-17 10:36 ` Brian Foster
2020-04-20 11:45 ` Chandan Rajendra
2020-04-20 16:20 ` Brian Foster
2020-04-20 23:26 ` Allison Collins
2020-04-03 22:12 ` [PATCH v8 20/20] xfs: Rename __xfs_attr_rmtval_remove Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429230909.GW6742@magnolia \
--to=darrick.wong@oracle.com \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).