Re: [PATCH 27/28] xfs: remove unnecessary includes from xfs_log_recover.c

Chandan Babu R
2020-05-06T07:21:57Z

On Tuesday 5 May 2020 6:43:24 AM IST Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Remove unnecessary includes from the log recovery code.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_log_recover.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 0c8a1f4bf4ad..a9cc546535e0 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -18,21 +18,13 @@
> #include "xfs_log.h"
> #include "xfs_log_priv.h"
> #include "xfs_log_recover.h"
> -#include "xfs_inode_item.h"
> -#include "xfs_extfree_item.h"
> #include "xfs_trans_priv.h"
> #include "xfs_alloc.h"
> #include "xfs_ialloc.h"
> -#include "xfs_quota.h"
> #include "xfs_trace.h"
> #include "xfs_icache.h"

Inclusion of xfs_icache.h can be removed as well. I have clarified this by
removing the above statement and successfully building the kernel.

The rest look good to me.

Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>

> -#include "xfs_bmap_btree.h"
> #include "xfs_error.h"
> -#include "xfs_dir2.h"
> -#include "xfs_rmap_item.h"
> #include "xfs_buf_item.h"
> -#include "xfs_refcount_item.h"
> -#include "xfs_bmap_item.h"
>
> #define BLK_AVG(blk1, blk2) ((blk1+blk2) >> 1)
>
>
>

--
chandan