From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 20/25] xfs: refactor adding recovered intent items to the log
Date: Wed, 6 May 2020 23:06:56 -0700 [thread overview]
Message-ID: <20200507060656.GA5335@infradead.org> (raw)
In-Reply-To: <158881342959.189971.5621808877331045450.stgit@magnolia>
On Wed, May 06, 2020 at 06:03:49PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> During recovery, every intent that we recover from the log has to be
> added to the AIL. Replace the open-coded addition with a helper.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-05-07 6:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 1:01 [PATCH v4 00/25] xfs: refactor log recovery Darrick J. Wong
2020-05-07 1:01 ` [PATCH 01/25] xfs: convert xfs_log_recover_item_t to struct xfs_log_recover_item Darrick J. Wong
2020-05-07 1:01 ` [PATCH 02/25] xfs: refactor log recovery item sorting into a generic dispatch structure Darrick J. Wong
2020-05-07 1:01 ` [PATCH 03/25] xfs: refactor log recovery item dispatch for pass2 readhead functions Darrick J. Wong
2020-05-07 1:02 ` [PATCH 04/25] xfs: refactor log recovery item dispatch for pass1 commit functions Darrick J. Wong
2020-05-07 1:02 ` [PATCH 05/25] xfs: refactor log recovery buffer item dispatch for pass2 " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 06/25] xfs: refactor log recovery inode " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 07/25] xfs: refactor log recovery dquot " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 08/25] xfs: refactor log recovery icreate " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 09/25] xfs: refactor log recovery EFI " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 10/25] xfs: refactor log recovery RUI " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 11/25] xfs: refactor log recovery CUI " Darrick J. Wong
2020-05-07 1:02 ` [PATCH 12/25] xfs: refactor log recovery BUI " Darrick J. Wong
2020-05-07 1:03 ` [PATCH 13/25] xfs: remove log recovery quotaoff " Darrick J. Wong
2020-05-07 1:03 ` [PATCH 14/25] xfs: refactor recovered EFI log item playback Darrick J. Wong
2020-05-07 1:03 ` [PATCH 15/25] xfs: refactor recovered RUI " Darrick J. Wong
2020-05-07 1:03 ` [PATCH 16/25] xfs: refactor recovered CUI " Darrick J. Wong
2020-05-07 1:03 ` [PATCH 17/25] xfs: refactor recovered BUI " Darrick J. Wong
2020-05-07 1:03 ` [PATCH 18/25] xfs: refactor xlog_item_is_intent now that we're done converting Darrick J. Wong
2020-05-07 1:03 ` [PATCH 19/25] xfs: refactor releasing finished intents during log recovery Darrick J. Wong
2020-05-07 1:03 ` [PATCH 20/25] xfs: refactor adding recovered intent items to the log Darrick J. Wong
2020-05-07 6:06 ` Christoph Hellwig [this message]
2020-05-07 1:03 ` [PATCH 21/25] xfs: refactor intent item RECOVERED flag into the log item Darrick J. Wong
2020-05-07 1:04 ` [PATCH 22/25] xfs: refactor intent item iop_recover calls Darrick J. Wong
2020-05-07 1:04 ` [PATCH 23/25] xfs: hoist setting of XFS_LI_RECOVERED to caller Darrick J. Wong
2020-05-07 1:04 ` [PATCH 24/25] xfs: move log recovery buffer cancellation code to xfs_buf_item_recover.c Darrick J. Wong
2020-05-07 1:04 ` [PATCH 25/25] xfs: remove unnecessary includes from xfs_log_recover.c Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507060656.GA5335@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox