From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3FFC38A2A for ; Fri, 8 May 2020 15:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4A66206B8 for ; Fri, 8 May 2020 15:10:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LaA2ocyN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbgEHPKi (ORCPT ); Fri, 8 May 2020 11:10:38 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50614 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbgEHPKh (ORCPT ); Fri, 8 May 2020 11:10:37 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048F7oEi126563; Fri, 8 May 2020 15:10:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=O7lOplm7pCgdHUiH5QTgt9I30rQfI8N+/Qda53tRRPo=; b=LaA2ocyNTcFpf0wXfhm0jwctrgMJO1j6bCbPqr97jXwfdddF8WS14F7dg5Wf2ku/fgbS f8oka6L4X9TpdgAlJwl39bVANpHSE14GhhWRCvZOZmn8rXrhjq//g+9Dd26X/0SkbgC/ F1hgU1iicj45BzY8VBgKXL5Sd+DoGP42EzEuCSHRoE/SLQ+G+mxqf9RoZ4Z+q+7i68pQ zVJxQHGaSLq1I0yjDL5yZ5N3oVyKmhaRVtWKylXNrkDqeAMzVastfZsIbgYbKMQnyOji PhPe9Z48oLJ5hwHxId7HigQ0CkT9u8zD9tHnA7bQgdhIxwkufR53FW9XQ3zFEg7Hrex6 tg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 30vtexugm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 15:10:29 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048F6vCA129575; Fri, 8 May 2020 15:08:29 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 30vtegxa3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 15:08:28 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 048F8ROk016508; Fri, 8 May 2020 15:08:27 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 May 2020 08:08:27 -0700 Date: Fri, 8 May 2020 08:08:27 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Brian Foster Subject: Re: [PATCH 01/12] xfs: xfs_bmapi_read doesn't take a fork id as the last argument Message-ID: <20200508150827.GK6714@magnolia> References: <20200508063423.482370-1-hch@lst.de> <20200508063423.482370-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508063423.482370-2-hch@lst.de> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080135 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 adultscore=0 spamscore=0 suspectscore=1 bulkscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080135 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, May 08, 2020 at 08:34:12AM +0200, Christoph Hellwig wrote: > The last argument to xfs_bmapi_raad contains XFS_BMAPI_* flags, not the > fork. Given that XFS_DATA_FORK evaluates to 0 no real harm is done, > but let's fix this anyway. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Brian Foster Heh. Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_rtbitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c > index f42c74cb8be53..9498ced947be9 100644 > --- a/fs/xfs/libxfs/xfs_rtbitmap.c > +++ b/fs/xfs/libxfs/xfs_rtbitmap.c > @@ -66,7 +66,7 @@ xfs_rtbuf_get( > > ip = issum ? mp->m_rsumip : mp->m_rbmip; > > - error = xfs_bmapi_read(ip, block, 1, &map, &nmap, XFS_DATA_FORK); > + error = xfs_bmapi_read(ip, block, 1, &map, &nmap, 0); > if (error) > return error; > > -- > 2.26.2 >