From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 08/12] xfs: remove xfs_ifork_ops
Date: Sat, 9 May 2020 10:17:15 +0200 [thread overview]
Message-ID: <20200509081715.GA21748@lst.de> (raw)
In-Reply-To: <20200508150543.GF27577@bfoster>
On Fri, May 08, 2020 at 11:05:43AM -0400, Brian Foster wrote:
> On Fri, May 08, 2020 at 08:34:19AM +0200, Christoph Hellwig wrote:
> > xfs_ifork_ops add up to two indirect calls per inode read and flush,
> > despite just having a single instance in the kernel. In xfsprogs
> > phase6 in xfs_repair overrides the verify_dir method to deal with inodes
> > that do not have a valid parent, but that can be fixed pretty easily
> > by ensuring they always have a valid looking parent.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> Code looks fine, but I assume we'll want a repair fix completed and
> merged before wiping this out:
With the xfsprogs merge delays I'm not sure merged will work, but I'll
happily take your patch and get it in shape for submission.
next prev parent reply other threads:[~2020-05-09 8:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:34 dinode reading cleanups v2 Christoph Hellwig
2020-05-08 6:34 ` [PATCH 01/12] xfs: xfs_bmapi_read doesn't take a fork id as the last argument Christoph Hellwig
2020-05-08 15:08 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 02/12] xfs: call xfs_iformat_fork from xfs_inode_from_disk Christoph Hellwig
2020-05-16 0:19 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 03/12] xfs: split xfs_iformat_fork Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 0:22 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 04/12] xfs: handle unallocated inodes in xfs_inode_from_disk Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 17:38 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 05/12] xfs: call xfs_dinode_verify from xfs_inode_from_disk Christoph Hellwig
2020-05-16 17:40 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 06/12] xfs: don't reset i_delayed_blks in xfs_iread Christoph Hellwig
2020-05-16 17:41 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 07/12] xfs: remove xfs_iread Christoph Hellwig
2020-05-16 17:43 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 08/12] xfs: remove xfs_ifork_ops Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-09 8:17 ` Christoph Hellwig [this message]
2020-05-09 11:13 ` Brian Foster
2020-05-16 17:48 ` Darrick J. Wong
2020-05-18 13:35 ` Brian Foster
2020-05-18 16:07 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 09/12] xfs: refactor xfs_inode_verify_forks Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 17:49 ` Darrick J. Wong
2020-05-17 7:58 ` Christoph Hellwig
2020-05-08 6:34 ` [PATCH 10/12] xfs: improve local fork verification Christoph Hellwig
2020-05-08 15:06 ` Brian Foster
2020-05-16 17:50 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 11/12] xfs: remove the special COW fork handling in xfs_bmapi_read Christoph Hellwig
2020-05-16 17:52 ` Darrick J. Wong
2020-05-17 7:56 ` Christoph Hellwig
2020-05-08 6:34 ` [PATCH 12/12] xfs: remove the NULL " Christoph Hellwig
2020-05-08 15:06 ` Brian Foster
2020-05-16 17:52 ` Darrick J. Wong
2020-05-18 6:48 ` dinode reading cleanups v2 Christoph Hellwig
2020-05-18 17:36 ` Darrick J. Wong
2020-05-18 17:45 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-05-01 8:14 dinode reading cleanups Christoph Hellwig
2020-05-01 8:14 ` [PATCH 08/12] xfs: remove xfs_ifork_ops Christoph Hellwig
2020-05-01 15:56 ` Brian Foster
2020-05-01 16:08 ` Darrick J. Wong
2020-05-01 16:38 ` Christoph Hellwig
2020-05-01 16:50 ` Christoph Hellwig
2020-05-01 18:23 ` Brian Foster
2020-05-07 12:34 ` Christoph Hellwig
2020-05-07 13:43 ` Brian Foster
2020-05-07 16:28 ` Brian Foster
2020-05-07 17:18 ` Christoph Hellwig
2020-05-12 23:50 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509081715.GA21748@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).