From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/8] db: add a comment to agfl_crc_flds
Date: Sat, 9 May 2020 10:07:12 -0700 [thread overview]
Message-ID: <20200509170712.GQ6714@magnolia> (raw)
In-Reply-To: <20200509170125.952508-4-hch@lst.de>
On Sat, May 09, 2020 at 07:01:20PM +0200, Christoph Hellwig wrote:
> Explain the bno field that is not actually part of the structure
> anymore.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> db/agfl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/db/agfl.c b/db/agfl.c
> index 45e4d6f9..ce7a2548 100644
> --- a/db/agfl.c
> +++ b/db/agfl.c
> @@ -47,6 +47,7 @@ const field_t agfl_crc_flds[] = {
> { "uuid", FLDT_UUID, OI(OFF(uuid)), C1, 0, TYP_NONE },
> { "lsn", FLDT_UINT64X, OI(OFF(lsn)), C1, 0, TYP_NONE },
> { "crc", FLDT_CRC, OI(OFF(crc)), C1, 0, TYP_NONE },
> + /* the bno array really is behind the actual structure */
Er... the bno array comes /after/ the actual structure, right?
--D
> { "bno", FLDT_AGBLOCKNZ, OI(bitize(sizeof(struct xfs_agfl))),
> agfl_bno_size, FLD_ARRAY|FLD_COUNT, TYP_DATA },
> { NULL }
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-09 17:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 17:01 misc xfsprogs cleanups after the 5.7 merge Christoph Hellwig
2020-05-09 17:01 ` [PATCH 1/8] libxfs: use tabs instead of spaces in div_u64 Christoph Hellwig
2020-05-09 17:06 ` Darrick J. Wong
2020-05-09 17:08 ` Eric Sandeen
2020-05-09 17:01 ` [PATCH 2/8] db: fix a comment in scan_freelist Christoph Hellwig
2020-05-09 17:06 ` Darrick J. Wong
2020-05-09 17:01 ` [PATCH 3/8] db: add a comment to agfl_crc_flds Christoph Hellwig
2020-05-09 17:07 ` Darrick J. Wong [this message]
2020-05-09 17:10 ` Christoph Hellwig
2020-05-09 17:32 ` Eric Sandeen
2020-05-09 19:18 ` Darrick J. Wong
2020-05-10 7:11 ` Christoph Hellwig
2020-05-09 17:01 ` [PATCH 4/8] db: cleanup attr_set_f and attr_remove_f Christoph Hellwig
2020-05-09 17:08 ` Darrick J. Wong
2020-05-09 17:23 ` Eric Sandeen
2020-05-10 7:11 ` Christoph Hellwig
2020-05-10 14:09 ` Eric Sandeen
2020-05-11 3:41 ` Darrick J. Wong
2020-05-11 13:21 ` Eric Sandeen
2020-05-09 17:01 ` [PATCH 5/8] db: validate name and namelen in " Christoph Hellwig
2020-05-09 17:09 ` Darrick J. Wong
2020-05-09 17:12 ` Christoph Hellwig
2020-05-09 17:01 ` [PATCH 6/8] db: ensure that create and replace are exclusive in attr_set_f Christoph Hellwig
2020-05-09 17:09 ` Darrick J. Wong
2020-05-09 17:01 ` [PATCH 7/8] repair: cleanup build_agf_agfl Christoph Hellwig
2020-05-09 17:11 ` Darrick J. Wong
2020-05-09 17:47 ` Eric Sandeen
2020-05-09 17:01 ` [PATCH 8/8] metadump: small cleanup for process_inode Christoph Hellwig
2020-05-09 17:11 ` Darrick J. Wong
2020-05-09 19:03 ` misc xfsprogs cleanups after the 5.7 merge Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509170712.GQ6714@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox