Re: [PATCH 04/16] xfs_repair: fix bnobt and refcountbt record order checks

Christoph Hellwig
2020-05-09T17:10:45Z

On Sat, May 09, 2020 at 09:30:17AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The bnobt and refcountbt scanners attempt to check that records are in
> the correct order. However, the lastblock variable in both functions
> ought to be set to the end of the previous record (instead of the start)
> because otherwise we fail to catch overlapping records, which are not
> allowed in either btree type.
>
> Found by running xfs/410 with recs[1].blockcount = middlebit.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>