Re: [PATCH v2 01/16] xfs_repair: fix missing dir buffer corruption checks

Darrick J. Wong
2020-05-13T15:37:23Z

On Tue, May 12, 2020 at 11:22:16PM -0700, Christoph Hellwig wrote:
> This looks ok, but it seems like da_read_buf should just return
> the error instead of the b_error mess, at whih point we'd basically
> have xfs_da_read_buf + the salvage flag. But I guess we can apply
> your patch first to let you make progress first and sort that
> out later:

<nod> I /think/ the value in repair's use of salvage mode here is to be
able to pinpoint exactly which dirent in a directory data block went
bad, and then to log that for the sysadmin as maybe a clue for renaming
files out of lost+found. We probably don't need salvage mode for
dabtree blocks since that's just indexing data that users never see
directly.

In theory we don't need salvage mode at all, but it's less exciting to
barf out the standard metadata verifier error and have nothing else to
say.

Anyway, thanks for the review.

--D

> Reviewed-by: Christoph Hellwig <hch@lst.de>