From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2] xfs_quota: refactor code to generate id from name
Date: Tue, 12 May 2020 01:09:29 -0700 [thread overview]
Message-ID: <20200512080929.GA28206@infradead.org> (raw)
In-Reply-To: <b5668fd4-7070-4afc-f556-8445ef41fab7@redhat.com>
> +static uint32_t
> +id_from_string(
> + char *name,
> + int type)
> +{
> + uint32_t id = -1;
> + const char *type_name = "unknown type";
Any reason to align the arguments different from the local variables?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-05-12 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 17:18 [PATCH] xfs_quota: refactor code to generate id from name Eric Sandeen
2020-05-11 15:32 ` Christoph Hellwig
2020-05-11 16:00 ` Eric Sandeen
2020-05-11 19:08 ` [PATCH V2] " Eric Sandeen
2020-05-12 8:09 ` Christoph Hellwig [this message]
2020-05-12 15:20 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512080929.GA28206@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox