From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH RFC] xfs: warn instead of fail verifier on empty attr3 leaf block
Date: Tue, 12 May 2020 09:03:00 -0700 [thread overview]
Message-ID: <20200512160300.GA4642@infradead.org> (raw)
In-Reply-To: <20200512155320.GD6714@magnolia>
On Tue, May 12, 2020 at 08:53:20AM -0700, Darrick J. Wong wrote:
> I was gonna say, I think we've messed this up enough that I think we
> just have to accept empty attr leaf blocks. :/
>
> I also think we should improve the ability to scan for and invalidate
> incore buffers so that we can invalidate and truncate the attr fork
> extents directly from an extent walk loop. It seems a little silly that
> we have to walk the dabtree just to find out where multiblock remote
> attr value structures might be hiding.
The buffers are indexed by the physical block number. Unless you
want to move to logical indexing that's what we'll need to do.
next prev parent reply other threads:[~2020-05-12 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 18:50 [PATCH RFC] xfs: warn instead of fail verifier on empty attr3 leaf block Brian Foster
2020-05-12 8:10 ` Christoph Hellwig
2020-05-12 15:53 ` Darrick J. Wong
2020-05-12 16:03 ` Christoph Hellwig [this message]
2020-05-12 16:19 ` Darrick J. Wong
2020-05-12 17:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512160300.GA4642@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox