From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CEDC2D0F8 for ; Tue, 12 May 2020 23:40:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B6B8206F5 for ; Tue, 12 May 2020 23:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726031AbgELXkz (ORCPT ); Tue, 12 May 2020 19:40:55 -0400 Received: from mail108.syd.optusnet.com.au ([211.29.132.59]:47113 "EHLO mail108.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgELXky (ORCPT ); Tue, 12 May 2020 19:40:54 -0400 Received: from dread.disaster.area (pa49-195-157-175.pa.nsw.optusnet.com.au [49.195.157.175]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 0F3141A843E; Wed, 13 May 2020 09:40:50 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jYeVz-0000uM-B6; Wed, 13 May 2020 09:40:47 +1000 Date: Wed, 13 May 2020 09:40:47 +1000 From: Dave Chinner To: Eric Sandeen Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH] xfsprogs: remove the libxfs_* API redirections Message-ID: <20200512234047.GX2040@dread.disaster.area> References: <20200512170303.1949761-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=ONQRW0k9raierNYdzxQi9Q==:117 a=ONQRW0k9raierNYdzxQi9Q==:17 a=kj9zAlcOel0A:10 a=sTwFKg_x9MkA:10 a=7-415B0cAAAA:8 a=PDsQQsCPsZuFtj1DX0gA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, May 12, 2020 at 12:06:46PM -0500, Eric Sandeen wrote: > On 5/12/20 12:03 PM, Christoph Hellwig wrote: > > For historical reasons xfsprogs tries to renamed xfs_* symbols used > > by tools (but not those used inside libxfs) to libxfs_. Remove this > > indirection to make it clear what function is being called, and to > > avoid having to keep the renaming header uptodate. > > > > Signed-off-by: Christoph Hellwig > > I'm fine with this. I'll wait a bit to see if Dave has a strong argument > against it, but TBH I have never understood the point of the renaming. It was done so there was a clear delineation between the functions that return negative errors (from the libxfs core) and anything else that was named "xfs_" in xfsprogs that returned positive errors. This was needed back when I had to bring xfsprogs up to date with the kernel after years of neglect and the kernel had moved to negative errnos.... If that's no longer a useful distinction, then it doesn't bother me if we get rid of it. Cheers, Dave. -- Dave Chinner david@fromorbit.com