From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: fix error code in xfs_iflush_cluster()
Date: Thu, 14 May 2020 07:09:16 +1000 [thread overview]
Message-ID: <20200513210916.GF2040@dread.disaster.area> (raw)
In-Reply-To: <20200513151754.GC1984748@magnolia>
On Wed, May 13, 2020 at 08:17:54AM -0700, Darrick J. Wong wrote:
> On Wed, May 13, 2020 at 04:39:05PM +0300, Dan Carpenter wrote:
> > Oh yeah. You're right. This patch isn't correct. Sorry about that.
> >
> > I worry that there are several static analyzer's which will warn about
> > this code...
>
> /me wonders if this particular instance ought to have a breadcrumb to
> remind future readers that we can handle the lack of memory, e.g.
>
> cilist = kmem_alloc(..., KM_MAYFAIL...);
> if (!cilist) {
> /* memory is tight, so defer the inode cluster flush */
> goto out_put;
> }
I'm working on patches that make this memory allocation go away
altogether, so I'd suggest just ignoring it for now.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2020-05-13 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 9:48 [PATCH] xfs: fix error code in xfs_iflush_cluster() Dan Carpenter
2020-05-13 13:29 ` Brian Foster
2020-05-13 13:39 ` Dan Carpenter
2020-05-13 15:17 ` Darrick J. Wong
2020-05-13 21:09 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513210916.GF2040@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox