From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_repair: remove gratuitous code block in phase5
Date: Thu, 14 May 2020 12:23:14 -0700 [thread overview]
Message-ID: <20200514192314.GE6714@magnolia> (raw)
In-Reply-To: <3b728076-0454-104c-312f-511447235f61@redhat.com>
On Mon, May 11, 2020 at 03:32:42PM -0500, Eric Sandeen wrote:
> On 5/11/20 2:20 PM, Eric Sandeen wrote:
> > A commit back in 2008 removed a "for" loop ahead of this code block, but
> > left the indented code block in place. Remove it for clarity and reflow
> > comments & lines as needed.
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Never mind, Darrick /just/ did this in his other series. Weird. I didn't
> see it there! ;)
>
> So ignore this patch.
Actually, I see that you fixed all the 80col stuff that I didn't.
Maybe I want this patch over yours after all. :P
--D
> -Eric
>
next prev parent reply other threads:[~2020-05-14 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 19:20 [PATCH] xfs_repair: remove gratuitous code block in phase5 Eric Sandeen
2020-05-11 20:32 ` Eric Sandeen
2020-05-14 19:23 ` Darrick J. Wong [this message]
2020-05-14 20:45 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514192314.GE6714@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox