Re: [PATCH 06/12] xfs: don't reset i_delayed_blks in xfs_iread

Darrick J. Wong
2020-05-16T17:41:44Z

On Fri, May 08, 2020 at 08:34:17AM +0200, Christoph Hellwig wrote:
> i_delayed_blks is set to 0 in xfs_inode_alloc and can't have anything
> assigned to it until the inode is visible to the VFS.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Brian Foster <bfoster@redhat.com>

Seems fine to me...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_inode_buf.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index 3aac22e892985..329534eebbdcc 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -663,8 +663,6 @@ xfs_iread(
> if (error)
> goto out_brelse;
>
> - ip->i_delayed_blks = 0;
> -
> /*
> * Mark the buffer containing the inode as something to keep
> * around for a while. This helps to keep recently accessed
> --
> 2.26.2
>