Re: [PATCH 01/12] xfs: xfs_bmapi_read doesn't take a fork id as the last argument

Darrick J. Wong
2020-05-08T15:10:38Z

On Fri, May 08, 2020 at 08:34:12AM +0200, Christoph Hellwig wrote:
> The last argument to xfs_bmapi_raad contains XFS_BMAPI_* flags, not the
> fork. Given that XFS_DATA_FORK evaluates to 0 no real harm is done,
> but let's fix this anyway.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Brian Foster <bfoster@redhat.com>

Heh.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_rtbitmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
> index f42c74cb8be53..9498ced947be9 100644
> --- a/fs/xfs/libxfs/xfs_rtbitmap.c
> +++ b/fs/xfs/libxfs/xfs_rtbitmap.c
> @@ -66,7 +66,7 @@ xfs_rtbuf_get(
>
> ip = issum ? mp->m_rsumip : mp->m_rbmip;
>
> - error = xfs_bmapi_read(ip, block, 1, &map, &nmap, XFS_DATA_FORK);
> + error = xfs_bmapi_read(ip, block, 1, &map, &nmap, 0);
> if (error)
> return error;
>
> --
> 2.26.2
>