From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH, RFCRAP] xfs: handle ENOSPC quota return in xfs_file_buffered_aio_write
Date: Sun, 17 May 2020 02:58:14 -0700 [thread overview]
Message-ID: <20200517095814.GA441@infradead.org> (raw)
In-Reply-To: <e6b9090b-722a-c9d1-6c82-0dcb3f0be5a2@redhat.com>
On Thu, May 14, 2020 at 04:43:36PM -0500, Eric Sandeen wrote:
> + if (ret == -EDQUOT ||
> + (ret == -ENOSPC && ip->i_pdquot &&
> + XFS_IS_PQUOTA_ENFORCED(mp) && ip->i_pdquot)) {
> + xfs_iunlock(ip, iolock);
> + enospc |= xfs_inode_free_quota_eofblocks(ip);
> + enospc |= xfs_inode_free_quota_cowblocks(ip);
> + iolock = 0;
Fun fact of the day: xfs_inode_free_quota_eofblocks and
xfs_inode_free_quota_cowblocks don't actually do anything for project
quotas. I've started to prepare a little cleanup series to help
implementing what you want. Give me some time to do a quick test
run and send it out.
next prev parent reply other threads:[~2020-05-17 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 21:43 [PATCH, RFCRAP] xfs: handle ENOSPC quota return in xfs_file_buffered_aio_write Eric Sandeen
2020-05-17 9:58 ` Christoph Hellwig [this message]
2020-05-18 12:34 ` Brian Foster
2020-05-18 17:01 ` Christoph Hellwig
2020-05-18 18:54 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517095814.GA441@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox