From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [ANNOUNCE] xfsprogs for-next updated to 5d0807ad
Date: Mon, 18 May 2020 09:11:41 -0700 [thread overview]
Message-ID: <20200518161141.GC17627@magnolia> (raw)
In-Reply-To: <20200518073246.GA7973@infradead.org>
On Mon, May 18, 2020 at 12:32:46AM -0700, Christoph Hellwig wrote:
> Btw, some time after xfsprogs 5.6, xfstests generic/590 start to fail
> with new xfs_check errors in the form of:
>
> rtblock 1048576 beyond end of expected area
> rtblock 1048576 beyond end of expected area
> rtblock 1048580 beyond end of expected area
> rtblock 1048580 beyond end of expected area
> rtblock 1048584 beyond end of expected area
> rtblock 1048584 beyond end of expected area
> rtblock 1048588 beyond end of expected area
> rtblock 1048588 beyond end of expected area
> rtblock 1048592 beyond end of expected area
> rtblock 1048592 beyond end of expected area
> rtblock 1048596 beyond end of expected area
> rtblock 1048596 beyond end of expected area
> rtblock 1048600 beyond end of expected area
>
>
That's probably the bounds check I added in commit
7161cd21b3ed3fa82aef1f13b2bcfae045208573
So either I've gotten the units wron.... aha, I see it:
static inline bool
rdbmap_boundscheck(
xfs_rfsblock_t bno)
{
return bno < mp->m_sb.sb_agblocks;
}
That should have been sb_rblocks.
--D
prev parent reply other threads:[~2020-05-18 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 21:41 [ANNOUNCE] xfsprogs for-next updated to 5d0807ad Eric Sandeen
2020-05-18 7:32 ` Christoph Hellwig
2020-05-18 16:11 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518161141.GC17627@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox