From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F7DC433E1 for ; Mon, 18 May 2020 16:59:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A894520758 for ; Mon, 18 May 2020 16:59:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VdtllQ2T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728198AbgERQ67 (ORCPT ); Mon, 18 May 2020 12:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbgERQ67 (ORCPT ); Mon, 18 May 2020 12:58:59 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F31C061A0C for ; Mon, 18 May 2020 09:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+3FHPwcXvpv730ElxvnFZTNme0UBLd50jDF0Sm9oxE4=; b=VdtllQ2TrTJsgpU/qiPvJqrA33 jv5/UVLMNqkCN57kgUCgoKHShDCVV3+KioFjNVjWTNQHjEG5o8IIzZ2JiDhu7dErI4EqVVMwmKYGe JZRM4ZcN40Fo/0RXPJUPyLgDxT6UmKGT9EqpF0KIxnKbqpE7efyZ01t0E47LPFquvVl2+3T9VczLL wOeIT898LYE6J9oyXgCoRnMaB1MTMaFPLtuBmPKLTXm7jUoOgXyMPrixX5UIOpGMWGwtEIhbiFsEH LaOWyOYuvDzzgZeAxJlzrZONvl0n4Csyzt3aSaAhDCgItFSX4sKLR0fHgCl5AV9lWWooYY9FKuFad e/7hUeYA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaj6Q-00056n-SL; Mon, 18 May 2020 16:58:58 +0000 Date: Mon, 18 May 2020 09:58:58 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: xfs , Brian Foster , david@fromorbit.com Subject: Re: [PATCH v2] xfs: use ordered buffers to initialize dquot buffers during quotacheck Message-ID: <20200518165858.GA18061@infradead.org> References: <20200514165658.GC6714@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514165658.GC6714@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org I would have split the addition of support for order buffers to the defer mechanism into a separate patch. Otherwise this looks good: Reviewed-by: Christoph Hellwig