From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] xfs: fix unecessary percpu counter overhead
Date: Wed, 20 May 2020 07:48:38 +1000 [thread overview]
Message-ID: <20200519214840.2570159-1-david@fromorbit.com> (raw)
Hi folks,
This is a resend of a patch from months ago that can be found here:
https://lore.kernel.org/linux-xfs/20191121004437.9633-1-david@fromorbit.com/
I've split it into two patches and cleaned it up further and
retested it, and all is good now.
Essentially it solves the problem of production systems taking
percpu_counter_sum() overhead in a hot path when the sum is only
used for debug purposes and not actually compiled in to production
kernels. As a further cleanup of this code, the error handling
never returns errors at all to the caller, so it's only
for debug purposes. Given that the error handling logic is wrong and
we throw it away on debug kernels anyway, just get rid of all of it.
Cheers,
Dave.
next reply other threads:[~2020-05-19 21:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 21:48 Dave Chinner [this message]
2020-05-19 21:48 ` [PATCH 1/2] xfs: gut error handling in xfs_trans_unreserve_and_mod_sb() Dave Chinner
2020-05-20 6:53 ` Christoph Hellwig
2020-05-20 7:03 ` Dave Chinner
2020-05-20 7:33 ` [PATCH 1/2 V2] " Dave Chinner
2020-05-20 7:48 ` Christoph Hellwig
2020-05-20 20:27 ` Darrick J. Wong
2020-05-20 21:55 ` Dave Chinner
2020-05-20 22:28 ` Darrick J. Wong
2020-05-20 22:37 ` Dave Chinner
2020-05-19 21:48 ` [PATCH 2/2] xfs: reduce free inode accounting overhead Dave Chinner
2020-05-20 6:56 ` Christoph Hellwig
2020-05-20 20:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519214840.2570159-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox