From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: remove the m_active_trans counter
Date: Wed, 20 May 2020 00:17:12 -0700 [thread overview]
Message-ID: <20200520071712.GB7008@infradead.org> (raw)
In-Reply-To: <20200520071339.GW2040@dread.disaster.area>
On Wed, May 20, 2020 at 05:13:39PM +1000, Dave Chinner wrote:
> > > @@ -883,9 +885,7 @@ xfs_quiesce_attr(
> > > {
> > > int error = 0;
> > >
> > > - /* wait for all modifications to complete */
> > > - while (atomic_read(&mp->m_active_trans) > 0)
> > > - delay(100);
> > > + cancel_delayed_work_sync(&mp->m_log->l_work);
> >
> > Shouldn't the cancel_delayed_work_sync for l_work in xfs_log_quiesce
> > be removed now given that we've already cancelled it here?
>
> No, because every other caller of xfs_log_quiesce() requires the
> work to be cancelled before the log is quiesced.
The only other caller is xfs_log_unmount, which could grow it. But
I guess an extra cancel isn't harmful in the end.
next prev parent reply other threads:[~2020-05-20 7:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 22:23 [PATCH 0/2 v3] xfs: improve transaction rate scalability Dave Chinner
2020-05-19 22:23 ` [PATCH 1/2] xfs: separate read-only variables in struct xfs_mount Dave Chinner
2020-05-20 6:57 ` Christoph Hellwig
2020-05-20 7:12 ` Dave Chinner
2020-05-20 9:43 ` Chaitanya Kulkarni
2020-05-20 20:44 ` Darrick J. Wong
2020-05-19 22:23 ` [PATCH 2/2] xfs: remove the m_active_trans counter Dave Chinner
2020-05-20 7:01 ` Christoph Hellwig
2020-05-20 7:13 ` Dave Chinner
2020-05-20 7:17 ` Christoph Hellwig [this message]
2020-05-20 20:47 ` Darrick J. Wong
2020-05-20 21:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520071712.GB7008@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox