From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs_db: don't crash if el_gets returns null
Date: Wed, 20 May 2020 10:36:23 -0700 [thread overview]
Message-ID: <20200520173623.GA1713@infradead.org> (raw)
In-Reply-To: <158984953767.623441.453227281468842512.stgit@magnolia>
On Mon, May 18, 2020 at 05:52:17PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> el_gets returns NULL if it fails to read any characters (due to EOF or
> errors occurred). strdup will crash if it is fed a NULL string, so
> check the return value to avoid segfaulting.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
And I'm pretty sure I've reviewed this before..
next prev parent reply other threads:[~2020-05-20 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 0:52 [PATCH 0/3] xfsprogs: random fixes Darrick J. Wong
2020-05-19 0:52 ` [PATCH 1/3] xfs_db: don't crash if el_gets returns null Darrick J. Wong
2020-05-19 1:55 ` Eric Sandeen
2020-05-20 17:36 ` Christoph Hellwig [this message]
2020-05-19 0:52 ` [PATCH 2/3] xfs_db: fix rdbmap_boundscheck Darrick J. Wong
2020-05-19 1:57 ` Eric Sandeen
2020-05-20 17:36 ` Christoph Hellwig
2020-05-19 0:52 ` [PATCH 3/3] debian: replace libreadline with libedit Darrick J. Wong
2020-05-19 1:58 ` Eric Sandeen
2020-05-20 17:37 ` Christoph Hellwig
2020-05-20 18:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520173623.GA1713@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox