Re: [PATCH 14/24] xfs: remove IO submission from xfs_reclaim_inode()

Dave Chinner
2020-05-23T22:35:08Z

On Sat, May 23, 2020 at 02:40:55AM -0700, Christoph Hellwig wrote:
> > +out_ifunlock:
> > + xfs_ifunlock(ip);
> > +out:
> > + xfs_iunlock(ip, XFS_ILOCK_EXCL);
> > + xfs_iflags_clear(ip, XFS_IRECLAIM);
> > + return false;
> >
> > reclaim:
>
> I find the reordering of the error handling to sit before the actual
> reclaim action here really weird to read. What about something like
> this folded in instead?

Yeah, once the writeback restart goes away, it does look somewhat
weird. I've been considering pulling the actual inode reclaim code
into it's own function, just to separate it from the "try-lock and
check if we can reclaim this inode" operations.

I'll have a look and see what falls out...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com