From: Brian Foster <bfoster@redhat.com>
To: bugzilla-daemon@bugzilla.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: Re: [Bug 207053] fsfreeze deadlock on XFS (the FIFREEZE ioctl and subsequent FITHAW hang indefinitely)
Date: Thu, 28 May 2020 06:47:30 -0400 [thread overview]
Message-ID: <20200528104730.GA16657@bfoster> (raw)
In-Reply-To: <bug-207053-201763-5gtgB3HOFs@https.bugzilla.kernel.org/>
On Thu, May 28, 2020 at 06:00:38AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=207053
>
> --- Comment #8 from Paul Furtado (paulfurtado91@gmail.com) ---
> The patches that came from this issue have given us many weeks of stability now
> and we were ready to declare this as totally fixed, however, we hit another
> instance of this issue this week which I'm assuming is probably on a slightly
> different and much rarer code path.
>
> Here's a link to the blocked tasks log (beware that it's 2MB due to endless
> processes getting hung inside the container once the filesystem was frozen):
> https://gist.githubusercontent.com/PaulFurtado/48253a6978763671f70dc94d933df851/raw/6bad12023ac56e9b6cb3dde771fcb5b15f0bd679/patched_kernel_fsfreeze_sys_w.log
>
This shows the eofblocks scan in the following (massaged) trace:
[1259466.349224] Workqueue: xfs-eofblocks/nvme4n1 xfs_eofblocks_worker [xfs]
[1259466.353550] Call Trace:
[1259466.359370] schedule+0x2f/0xa0
[1259466.362297] rwsem_down_read_slowpath+0x196/0x530
[1259466.372467] __percpu_down_read+0x49/0x60
[1259466.375778] __sb_start_write+0x5b/0x60
[1259466.379139] xfs_trans_alloc+0x152/0x160 [xfs]
[1259466.382715] xfs_free_eofblocks+0x12d/0x1f0 [xfs]
[1259466.386407] xfs_inode_free_eofblocks+0x128/0x1a0 [xfs]
[1259466.394058] xfs_inode_ag_walk.isra.17+0x1a7/0x410 [xfs]
[1259466.536551] xfs_inode_ag_iterator_tag+0x73/0xb0 [xfs]
[1259466.540235] xfs_eofblocks_worker+0x29/0x40 [xfs]
[1259466.543748] process_one_work+0x195/0x380
[1259466.546996] worker_thread+0x30/0x390
[1259466.553449] kthread+0x113/0x130
[1259466.559579] ret_from_fork+0x1f/0x40
This should be addressed by upstream commit 4b674b9ac8529 ("xfs: acquire
superblock freeze protection on eofblocks scans"), which causes
xfs_eofblocks_worker() to bail unless it acquires freeze write
protection. What exact kernel is this seen on?
Brian
> Thanks,
> Paul
>
> --
> You are receiving this mail because:
> You are watching the assignee of the bug.
>
next prev parent reply other threads:[~2020-05-28 10:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 19:02 [Bug 207053] New: fsfreeze deadlock on XFS (the FIFREEZE ioctl and subsequent FITHAW hang indefinitely) bugzilla-daemon
2020-04-02 0:15 ` Dave Chinner
2020-04-02 0:15 ` [Bug 207053] " bugzilla-daemon
2020-04-07 6:41 ` bugzilla-daemon
2020-04-07 13:18 ` Brian Foster
2020-04-07 15:17 ` Darrick J. Wong
2020-04-07 16:37 ` Brian Foster
2020-04-07 16:49 ` Darrick J. Wong
2020-04-07 17:02 ` Brian Foster
2020-04-07 13:18 ` bugzilla-daemon
2020-04-07 15:17 ` bugzilla-daemon
2020-04-07 16:37 ` bugzilla-daemon
2020-04-07 16:49 ` bugzilla-daemon
2020-04-07 17:02 ` bugzilla-daemon
2020-05-28 6:00 ` bugzilla-daemon
2020-05-28 10:47 ` Brian Foster [this message]
2020-05-28 10:47 ` bugzilla-daemon
2020-05-28 16:16 ` bugzilla-daemon
2023-03-16 18:30 ` bugzilla-daemon
2023-03-16 21:02 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528104730.GA16657@bfoster \
--to=bfoster@redhat.com \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).