From: Gao Xiang <hsiangkao@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v3] xfs: get rid of unnecessary xfs_perag_{get,put} pairs
Date: Sat, 6 Jun 2020 02:47:32 +0800 [thread overview]
Message-ID: <20200605184732.GB4468@xiangao.remote.csb> (raw)
In-Reply-To: <20200605183037.GA4468@xiangao.remote.csb>
On Sat, Jun 06, 2020 at 02:30:37AM +0800, Gao Xiang wrote:
...
> >
> > Alternately-- if you want to sanity check that b_pag and the buffer
> > belong to the same ag, why not do that in xfs_buf_find for all the
> > buffers?
>
> Since that modification doesn't relate to this patch though (since
> the purpose of this patch is not add ASSERT to xfs_buf_find).
>
> If in that way, I think we can just kill all these ASSERTs.
Add some to the previous words:
What I really concern is to avoid introduce some regression from
this trivial patch. That is the original reason why I added these
assertions and tested with stress.
If some of these seems useful to the codebase, I could leave them
in this patch (since these are related to the modification of this
patch). Otherwise, I'd suggest kill them all though as I mentioned
earilier in the reply of v1.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2020-06-05 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 14:52 [PATCH] xfs: get rid of unnecessary xfs_perag_{get,put} pairs Gao Xiang
2020-06-03 0:22 ` Darrick J. Wong
2020-06-03 0:44 ` Dave Chinner
2020-06-03 0:48 ` Darrick J. Wong
2020-06-03 0:49 ` Gao Xiang
2020-06-03 1:27 ` Dave Chinner
2020-06-03 1:40 ` Gao Xiang
2020-06-03 3:02 ` Dave Chinner
2020-06-03 3:19 ` Gao Xiang
2020-06-03 12:11 ` [PATCH v2] " Gao Xiang
2020-06-04 21:59 ` Dave Chinner
2020-06-05 1:44 ` Gao Xiang
2020-06-05 8:52 ` [PATCH v3] " Gao Xiang
2020-06-05 15:56 ` Darrick J. Wong
2020-06-05 18:30 ` Gao Xiang
2020-06-05 18:47 ` Gao Xiang [this message]
2020-06-23 10:08 ` Gao Xiang
2020-07-13 8:53 ` [PATCH v4] " Gao Xiang
2020-07-13 16:12 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605184732.GB4468@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).