From: Gao Xiang <hsiangkao@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [RFC PATCH] xfs_repair: fix rebuilding btree node block less than minrecs
Date: Wed, 10 Jun 2020 09:04:03 +0800 [thread overview]
Message-ID: <20200610010403.GA29545@xiangao.remote.csb> (raw)
In-Reply-To: <20200609221239.GE11245@magnolia>
Hi Darrick,
On Tue, Jun 09, 2020 at 03:12:39PM -0700, Darrick J. Wong wrote:
...
>
> Oops, I hit send too quickly; the computation looks ok to me.
>
> Granted that's probably due to having written another btree geometry
> calculation function. :D
>
> Also, I think init_rmapbt_cursor does a similar trick and therefore
> suffers from a similar bug. See the comment "Leave enough slack in the
> rmapbt that we can insert..." around line 1412 or so?
These comments are fine :) I will try to fix them all in the next version.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2020-06-10 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 11:40 [RFC PATCH] xfs_repair: fix rebuilding btree node block less than minrecs Gao Xiang
2020-06-09 14:35 ` Gao Xiang
2020-06-09 20:14 ` Darrick J. Wong
2020-06-09 22:12 ` Darrick J. Wong
2020-06-10 1:04 ` Gao Xiang [this message]
2020-06-10 3:58 ` [RFC PATCH v2] xfs_repair: fix rebuilding btree " Gao Xiang
2020-06-10 5:26 ` [RFC PATCH v3] " Gao Xiang
2020-06-16 16:11 ` Darrick J. Wong
2020-06-16 17:26 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610010403.GA29545@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox