From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v3] xfs_copy: flush target devices before exiting
Date: Fri, 19 Jun 2020 09:17:32 +1000 [thread overview]
Message-ID: <20200618231732.GL2005@dread.disaster.area> (raw)
In-Reply-To: <20200618181825.GY11245@magnolia>
On Thu, Jun 18, 2020 at 11:18:25AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Flush the devices we're copying to before exiting, so that we can report
> any write errors.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks ok. Flushing in check_errors() is a bit nasty, but it's a copy
completion path that is called from many places so there's no
obvious alternative...
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2020-06-18 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 18:18 [PATCH v3] xfs_copy: flush target devices before exiting Darrick J. Wong
2020-06-18 23:17 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618231732.GL2005@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox