Re: [PATCH v3] xfs_copy: flush target devices before exiting

Dave Chinner
2020-06-18T23:17:59Z

On Thu, Jun 18, 2020 at 11:18:25AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Flush the devices we're copying to before exiting, so that we can report
> any write errors.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks ok. Flushing in check_errors() is a bit nasty, but it's a copy
completion path that is called from many places so there's no
obvious alternative...

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com