From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA3CC433E0 for ; Fri, 19 Jun 2020 13:32:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAE6920771 for ; Fri, 19 Jun 2020 13:32:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="W4ieGNUm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731398AbgFSNcZ (ORCPT ); Fri, 19 Jun 2020 09:32:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbgFSNcY (ORCPT ); Fri, 19 Jun 2020 09:32:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D42C06174E for ; Fri, 19 Jun 2020 06:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DSOOrdHZToroF+5V56lASZ3tXXvMksIFxXSvVyBUEgo=; b=W4ieGNUmlbT0qCcY/GiKrHWwuw vLPoSCkVPVokwNcnq5LdDaeVzbtwgNA8858+RX3NdUdi2ANkK8oOWUTLFnUlfG92VyMox91xMa4ar HG6BSKJ26FAiLye5UUTgnqmHaHILbM6qCrDAtQ9YfcqeBqxz4L9JxGyRUT2rKshmFFvttk70MUXGl XqFRSZsX3I+eC9/5ovkSs3cwx4Mjvrnz23L9Y3300Xfkhi5NL5boKMukGwxlD7XGNwrrVGEgyGQWx QaMPg1U7nut1bOx+616fjLh1GV2N7xtoFMOl9V5IY0OBTj4bog5+5vE5YnggrrMM5iUrgUD+w0rm6 lFjr6pqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmH83-0008Ha-DJ; Fri, 19 Jun 2020 13:32:23 +0000 Date: Fri, 19 Jun 2020 06:32:23 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 01/17] xfs_quota: fix unsigned int id comparisons Message-ID: <20200619133223.GA19124@infradead.org> References: <159107190111.313760.8056083399475334567.stgit@magnolia> <159107190741.313760.11195530788081068638.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159107190741.313760.11195530788081068638.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jun 01, 2020 at 09:25:07PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Fix compiler warnings about unsigned int comparisons by replacing them > with an explicit check for the one possible invalid value (-1U). > id_from_string sets exitcode to nonzero when it sees this value, so the > call sites don't have to do that. > > Coverity-id: 1463855, 1463856, 1463857 > Fixes: 67a73d6139d0 ("xfs_quota: refactor code to generate id from name") > Fixes: 36dc471cc9bb ("xfs_quota: allow individual timer extension") > Signed-off-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig