From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: kernel test robot <lkp@intel.com>
Cc: kbuild@lists.01.org, Dan Carpenter <error27@gmail.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [kbuild] fs/xfs/libxfs/xfs_bmap.c:5563 __xfs_bunmapi() warn: Function too hairy. No more merges.
Date: Mon, 22 Jun 2020 09:15:32 -0700 [thread overview]
Message-ID: <20200622161532.GD11242@magnolia> (raw)
In-Reply-To: <202006210453.AJzaq6rh%lkp@intel.com>
On Sun, Jun 21, 2020 at 04:03:02AM +0800, kernel test robot wrote:
> CC: kbuild-all@lists.01.org
> CC: linux-kernel@vger.kernel.org
> TO: Dave Chinner <dchinner@redhat.com>
> CC: "Darrick J. Wong" <darrick.wong@oracle.com>
> CC: Christoph Hellwig <hch@lst.de>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162
> commit: b0dff466c00975a3e3ec97e6b0266bfd3e4805d6 xfs: separate read-only variables in struct xfs_mount
> date: 3 weeks ago
> :::::: branch date: 24 hours ago
> :::::: commit date: 3 weeks ago
> config: i386-randconfig-m021-20200621 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> fs/xfs/libxfs/xfs_bmap.c:5563 __xfs_bunmapi() warn: Function too hairy. No more merges.
>
> Old smatch warnings:
> fs/xfs/libxfs/xfs_bmap.c:5450 __xfs_bunmapi() error: we previously assumed 'tp' could be null (see line 5290)
> fs/xfs/libxfs/xfs_bmap.c:6123 __xfs_bmap_add() error: potential null dereference 'bi'. (kmem_alloc returns null)
Er... does this mean that smatch is smarter about kmem_alloc now?
Or merely that something/someone tweaked the hair threshold downwards?
<-- his personal hair threshold is much longer now that it's March 98th.
--D
>
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0dff466c00975a3e3ec97e6b0266bfd3e4805d6
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git remote update linus
> git checkout b0dff466c00975a3e3ec97e6b0266bfd3e4805d6
> vim +5563 fs/xfs/libxfs/xfs_bmap.c
<snip> a ton of git blame output
next parent reply other threads:[~2020-06-22 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202006210453.AJzaq6rh%lkp@intel.com>
2020-06-22 16:15 ` Darrick J. Wong [this message]
2020-06-23 8:05 ` [kbuild] Re: fs/xfs/libxfs/xfs_bmap.c:5563 __xfs_bunmapi() warn: Function too hairy. No more merges Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622161532.GD11242@magnolia \
--to=darrick.wong@oracle.com \
--cc=error27@gmail.com \
--cc=kbuild@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox